Till Westmann has posted comments on this change. Change subject: Add Record To Map Methods ......................................................................
Patch Set 1: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1198/1/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangRecordParseUtil.java File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/LangRecordParseUtil.java: Line 218: } > Maybe can we utilize ConstantExpressionUtil class here? ConstantExpressionUtil is used to get a constant from an ILogicalExpression while we deal with the AST here ... -- To view, visit https://asterix-gerrit.ics.uci.edu/1198 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I525b99fa56251579e3ba42d79dd578c625fcab67 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
