Till Westmann has posted comments on this change. Change subject: HTTP API++, NCService Termination After Dead NCService ......................................................................
Patch Set 5: Code-Review+2 (2 comments) Looks good. Just one question in 2 places, but it seems like a corner case that we don't need to address right now. https://asterix-gerrit.ics.uci.edu/#/c/1193/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java: Line 77: nc.put(NCSERVICE_PID, details.getJSONObject(INI).getInt(NCSERVICE_PID)); When running with the integration util, I get an ncservice_pid of 0. Should we choose another default? (Seems that we shouldn't put a lot of effort into creating special cases for the integration util, so "no" sounds like a good default answer ...) https://asterix-gerrit.ics.uci.edu/#/c/1193/5/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/NCConfig.java: Line 264: if (ncservicePid != 0) { For some reason I'm getting a '0' ncservice-pid in the integration util. -- To view, visit https://asterix-gerrit.ics.uci.edu/1193 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia48eb16696e48444f610fd5e8d7d4666d0257a38 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
