Jianfeng Jia has posted comments on this change. Change subject: Fix for ASTERIXDB-1636 ......................................................................
Patch Set 4: (1 comment) I think maybe Taewoo knows better about the changes. Do we have some sort of unit test for storage codes? this kind of issue is impossible to be detected by AQL test. https://asterix-gerrit.ics.uci.edu/#/c/1205/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java: Line 1956: filterFields[0] = (numTokenFields + primaryKeys.size()) - 1; why minus 1? -- To view, visit https://asterix-gerrit.ics.uci.edu/1205 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4bc413fcda9a5c98ae57f94e1c8a68fe9aacda3 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Jianfeng Jia <jianfeng....@gmail.com> Gerrit-Reviewer: Taewoo Kim <wangs...@yahoo.com> Gerrit-HasComments: Yes
