Change in asterixdb[master]: JIT Logger Instantiation For Entry Points

[Michael Blow (Code Review)]

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1212

Change subject: JIT Logger Instantiation For Entry Points
......................................................................

JIT Logger Instantiation For Entry Points

Defer accessing the logger subsystem at static initialization time for
entry point classes, to give opportunity for extensions to configure
logging.

Change-Id: I33fa8f5d336b62ce6eddd49cd4e8fb28b4833eb0
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
3 files changed, 21 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/12/1212/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
index 7a9f654..dc0087b 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
@@ -18,6 +18,8 @@
  */
 package org.apache.asterix.api.common;
 
+import static 
org.apache.asterix.api.common.AsterixHyracksIntegrationUtil.LoggerHolder.LOGGER;
+
 import java.io.File;
 import java.net.Inet4Address;
 import java.util.ArrayList;
@@ -44,7 +46,12 @@
 import org.apache.hyracks.control.nc.NodeControllerService;
 
 public class AsterixHyracksIntegrationUtil {
-    private static final Logger LOGGER = 
Logger.getLogger(AsterixHyracksIntegrationUtil.class.getName());
+    static class LoggerHolder {
+        static final Logger LOGGER = 
Logger.getLogger(AsterixHyracksIntegrationUtil.class.getName());
+        private LoggerHolder() {
+        }
+    }
+
     private static final String IO_DIR_KEY = "java.io.tmpdir";
     public static final int DEFAULT_HYRACKS_CC_CLIENT_PORT = 1098;
     public static final int DEFAULT_HYRACKS_CC_CLUSTER_PORT = 1099;
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
index f6dfe4a..63cd196 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
@@ -20,6 +20,7 @@
 
 import static 
org.apache.asterix.api.http.servlet.ServletConstants.ASTERIX_BUILD_PROP_ATTR;
 import static 
org.apache.asterix.api.http.servlet.ServletConstants.HYRACKS_CONNECTION_ATTR;
+import static 
org.apache.asterix.hyracks.bootstrap.CCApplicationEntryPoint.LoggerHolder.LOGGER;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -77,8 +78,11 @@
 import org.eclipse.jetty.servlet.ServletMapping;
 
 public class CCApplicationEntryPoint implements ICCApplicationEntryPoint {
-
-    private static final Logger LOGGER = 
Logger.getLogger(CCApplicationEntryPoint.class.getName());
+    static class LoggerHolder {
+        static final Logger LOGGER = 
Logger.getLogger(CCApplicationEntryPoint.class.getName());
+        private LoggerHolder() {
+        }
+    }
 
     private List<Server> servers;
 
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
index c678bf3..81ecc67 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/NCApplicationEntryPoint.java
@@ -18,6 +18,8 @@
  */
 package org.apache.asterix.hyracks.bootstrap;
 
+import static 
org.apache.asterix.hyracks.bootstrap.NCApplicationEntryPoint.LoggerHolder.LOGGER;
+
 import java.io.File;
 import java.util.Collections;
 import java.util.HashMap;
@@ -59,7 +61,11 @@
 import org.kohsuke.args4j.Option;
 
 public class NCApplicationEntryPoint implements INCApplicationEntryPoint {
-    private static final Logger LOGGER = 
Logger.getLogger(NCApplicationEntryPoint.class.getName());
+    static class LoggerHolder {
+        static final Logger LOGGER = 
Logger.getLogger(NCApplicationEntryPoint.class.getName());
+        private LoggerHolder() {
+        }
+    }
 
     @Option(name = "-metadata-port", usage = "IP port to bind metadata 
listener (default: random port)",
             required = false)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1212
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33fa8f5d336b62ce6eddd49cd4e8fb28b4833eb0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>