Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1642,ASTERIXDB-1657,ASTERIXDB-1658 Fix Failure Handling ......................................................................
Patch Set 4: Code-Review+1 (3 comments) I don't see any red flags, but I'm a little concerned about the fact that in this change we send one instead of 2 messages to start a job. But I don't think that this would have a significant impact on most requests. More generally, I'm not too familiar with this code and I'd appreciate another review form somebody more familiar with with code. https://asterix-gerrit.ics.uci.edu/#/c/1197/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/scheduler/JobScheduler.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/scheduler/JobScheduler.java: Line 686: if (lastTaskClusterAttempt != null && (lastTaskClusterAttempt I think that it'd be good to pull the null check out, extract the status once and then compare that one status value to the 2 candidates. https://asterix-gerrit.ics.uci.edu/#/c/1197/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/ipc/CCNCFunctions.java: Line 112: public SendApplicationMessageFunction(byte[] data, DeploymentId deploymentId, String nodeId) { Is there any change in addition to moving it around? https://asterix-gerrit.ics.uci.edu/#/c/1197/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartJobWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartJobWork.java: Line 66: // TODO(amoudi) notify cc of start job failure That seems important ... -- To view, visit https://asterix-gerrit.ics.uci.edu/1197 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ec2c798b704ca426d5937f22e6d2bd394a9095a Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
