Yingyi Bu has posted comments on this change. Change subject: Revise the data model document. ......................................................................
Patch Set 1: (9 comments) https://asterix-gerrit.ics.uci.edu/#/c/1206/1/asterixdb/asterix-doc/src/site/markdown/aql/datamodel.md File asterixdb/asterix-doc/src/site/markdown/aql/datamodel.md: Line 42: * [Special Types] (#SpecialTypes) > We can leave this as-is, but I don't like "special" as it's too generic. I Done Line 80: `int` is an abbreviated alias for integer. > Is this how it's implemented? I thought that we had started to equate integ Yes, this is what's in the master. >>" I thought that we had started to equate integer with int64 ..." We previously didn't have a type name "integer". What we did is to let a constant integer value to be a bigint(int64) by default. This is still the case in the current master. For example, if you say: 1+1; it will return: 2 the types of the constants are bigint. Since we removed suffixes like "i8", "i16", "i32", etc, a user wouldn't tell what the actual type those constants are. Line 112: { "v1": double("NaN"), "v2": double("INF"), "v3": double("-INF"), "v4": double("-2013.593823748327284") }; > It seems bad, that we don't have double literals, do we have an issue for t Done Line 339: A `null` represent an unknown value. > s/represent/represents/ Done Line 340: For example, a user might not be able to know the value of a field and initially set it to `null` > "Setting" the value sounds like we can modify the data model instances, but Done Line 357: Because AsterixDB does not enforce homogeneity for datasets or collections, > It would be nice if we could make this doc less system specific. E.g. "as n Done Line 359: so a field can be present in one document and `missing` in another. > s/document/record/? Or move to "object"? Done Line 393: A `multiset` is a generalization of the concept of a set that, unlike a set, allows multiple instances of the multiset's elements. Multiset constructors are denoted by two opening flower braces followed by data and two closing flower braces, like "{{...}}". > s/flower/curly/? Done https://asterix-gerrit.ics.uci.edu/#/c/1206/1/asterixdb/asterix-doc/src/site/markdown/index.md File asterixdb/asterix-doc/src/site/markdown/index.md: Line 29: * Two expressive and declarative query languages (SQL++ and AQL) that supports a broad > s/supports/support/ Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1206 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c51f4f14ce7c16c98ea67503488e69e19d9195d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
