Yingyi Bu has posted comments on this change. Change subject: AbstractWork does not implement Runnable anymore ......................................................................
Patch Set 1: Code-Review+2 (1 comment) Only one comment. But feel free to ignore that. https://asterix-gerrit.ics.uci.edu/#/c/1218/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/AbstractWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/AbstractWork.java: Line 22: Could you use an interface for that, e.g., IWork? (Just my personal preference:-) ) Existing public method implementation could be kept by adding a "default". -- To view, visit https://asterix-gerrit.ics.uci.edu/1218 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53e77af9edc945fbea2a19a20b6d1f7568ac6b3a Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
