Taewoo Kim has posted comments on this change. Change subject: Full-text implementation step 1 ......................................................................
Patch Set 1: (21 comments) https://asterix-gerrit.ics.uci.edu/#/c/1228/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FullTextContainsParameterCheckRule.java: Line 86: IOptimizationContext context, IVariableTypeEnvironment env, AqlMetadataProvider metadataProvider) > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1228/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/util/FunctionCollection.java: Line 134: import org.apache.asterix.runtime.evaluators.functions.*; I am not sure why this happened. Eclipse did this. Let me know if we need to revive this. https://asterix-gerrit.ics.uci.edu/#/c/1228/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/FullTextContainsEvaluator.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/FullTextContainsEvaluator.java: Line 58: protected final int typeIndicatorSize = 1; > MAJOR SonarQube violation: Done Line 79: private final IBinaryComparator strLowerCaseTokenCmp = AqlBinaryComparatorFactoryProvider.UTF8STRING_LOWERCASE_TOKEN_POINTABLE_INSTANCE > MAJOR SonarQube violation: N/A Line 81: private final IBinaryComparator strLowerCaseCmp = AqlBinaryComparatorFactoryProvider.UTF8STRING_LOWERCASE_POINTABLE_INSTANCE > MAJOR SonarQube violation: N/A Line 214: System.out.println(t); > MAJOR SonarQube violation: Done Line 215: System.out.println( > MAJOR SonarQube violation: Done Line 219: // Reintroduce the typeTag for (Un)OrderedList. > MAJOR SonarQube violation: Done Line 380: private void setFullTextOption(ATypeTag[] typeTagOptions, IPointable[] argOptions, int uniqueQueryTokenCount) > MAJOR SonarQube violation: Done Line 384: if (compareStringInByteArrayAndPointable(FullTextContainsDescriptor.getSearchModeOptionArray(), argOptions[i], > MAJOR SonarQube violation: Done Line 390: } else if (compareStringInByteArrayAndPointable(FullTextContainsDescriptor.getConjunctiveFTSearchOptionArray(), > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1228/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/FullTextContainsDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/FullTextContainsDescriptor.java: Line 41: public static final LinkedHashMap<String, ATypeTag> paramTypeMap = new LinkedHashMap<>(); > MAJOR SonarQube violation: Done Line 43: public static final String searchModeOption = "mode"; > MAJOR SonarQube violation: Done Line 44: public static final String disjunctiveSearchModeOption = "any"; > MAJOR SonarQube violation: Done Line 45: public static final String conjunctiveSearchModeOption = "all"; > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1228/1/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/BinaryHashSet.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/BinaryHashSet.java: Line 267: ByteBuffer frame = null; > MAJOR SonarQube violation: Done Line 268: int frameNum = -1; > MAJOR SonarQube violation: Done Line 269: int frameOff = -1; > MAJOR SonarQube violation: Done Line 270: int headPtr = 0; > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1228/1/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/string/UTF8StringUtil.java File hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/string/UTF8StringUtil.java: Line 393: ch1 = (charAt(thisBytes, thisActualStart + c1)); > MAJOR SonarQube violation: Done Line 394: ch2 = (charAt(thatBytes, thatActualStart + c2)); > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1228 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If00a871a8241d6aa6931f97b694d65f164d3ab8c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-HasComments: Yes
