Michael Blow has posted comments on this change. Change subject: log request in QueryServiceServlet ......................................................................
Patch Set 1: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1232/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java: Line 235: public StringBuilder append(final StringBuilder sb) { I kinda feel like appendTo() makes more sense than append(), since you're not appending the thing you pass in, you are appending to it. Anyway, not enough to hold up the +2. -- To view, visit https://asterix-gerrit.ics.uci.edu/1232 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iceb265553bd20f4ab964a769892169f2c62e44a4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
