Till Westmann has posted comments on this change. Change subject: Revise builtin function documents. ......................................................................
Patch Set 4: (20 comments) Did not review spatial, temporal, and similarity functions. https://asterix-gerrit.ics.uci.edu/#/c/1221/4/asterixdb/asterix-doc/src/main/markdown/builtins/11_others.md File asterixdb/asterix-doc/src/main/markdown/builtins/11_others.md: Line 113: len(["ASTERIX", "Hyracks"]) More generic strings? Line 222: * `expr2`: an expression. Consistent spacing? Line 231: deep_equal( That's a lot of indentation ... https://asterix-gerrit.ics.uci.edu/#/c/1221/4/asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric.md File asterixdb/asterix-doc/src/main/markdown/builtins/1_numeric.md: Line 205: * Computes the e<sup>numeric_value</sup>. s/the// Line 260: * Computes the log<sub>e</sub>numeric_value. s/the// Line 284: * Computes the log<sub>10</sub>numeric_value. s/the// Line 308: * Computes the numeric_value1<sup>numeric_value2</sup>. s/the// https://asterix-gerrit.ics.uci.edu/#/c/1221/4/asterixdb/asterix-doc/src/main/markdown/builtins/2_string.md File asterixdb/asterix-doc/src/main/markdown/builtins/2_string.md: Line 608: substring_before(" like iphone", "iphone"); expected result? Line 634: " is great" Seems wrong. Line 688: * The expected result is: ?? https://asterix-gerrit.ics.uci.edu/#/c/1221/4/asterixdb/asterix-doc/src/main/markdown/builtins/3_binary.md File asterixdb/asterix-doc/src/main/markdown/builtins/3_binary.md: Line 43: [ hex("ABCDEF0123456789"), hex("ABCDEF0123456789"), hex("4173746572697801") ] This looks a little strange - seems that we should not allow printing of binaries ... not sure. Maybe file an issue? https://asterix-gerrit.ics.uci.edu/#/c/1221/4/asterixdb/asterix-doc/src/main/markdown/builtins/7_allens.md File asterixdb/asterix-doc/src/main/markdown/builtins/7_allens.md: Line 24: interval_before(interval1, interval2) Do we cover intervals in the data model doc? https://asterix-gerrit.ics.uci.edu/#/c/1221/4/asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md File asterixdb/asterix-doc/src/main/markdown/builtins/8_record.md: Line 149: * Add fields from a record given a list of field names. s/from/to/ https://asterix-gerrit.ics.uci.edu/#/c/1221/4/asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_aql.md File asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_aql.md: Line 104: * Gets the min value of numeric items in the given collection. Doesn't work for other comparable values? https://asterix-gerrit.ics.uci.edu/#/c/1221/4/asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md File asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md: Line 32: array_count(collection) This should follow our latest array_ vs coll_ discussion. Line 109: * Gets the min value of numeric items in the given collection. Doesn't work for other comparable values? Line 137: * Gets the max value of numeric items in the given collection. Doesn't work for other comparable values? Line 245: * Gets the min value of non-null and non-missing numeric items in the given collection. Doesn't work for other comparable values? Line 273: * Gets the max value of the non-null and non-missing numeric items in the given collection. Doesn't work for other comparable values? https://asterix-gerrit.ics.uci.edu/#/c/1221/4/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md File asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md: Line 596: | ARRAY_COUNT | counted | counted | 0 | Should follow our latest ARRAY_ vs COLL_ discussion. -- To view, visit https://asterix-gerrit.ics.uci.edu/1221 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b05108b1bc741585717192b0b721ad00959bd83 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
