abdullah alamoudi has posted comments on this change. Change subject: Fix potential hanging in op.initialize(). ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1243/3/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/ExceptionOnCreatePushRuntimeOperatorDescriptor.java File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/ExceptionOnCreatePushRuntimeOperatorDescriptor.java: Line 134: // should be executed. let's fix the comment and then: instead of using atomic integers, lets' use mutable static int[]s where the size = the number of partitions. we can set the int[]s before creating the jobs and then starts the job, each task will then work on its own createPushRuntime[partition], openCloseCounter[partition], and initializeCounter[partition]. then in succeed(), we can check that the values in all of the counters == 0. that is more precise and would tell us if exactly what we expect is happening. -- To view, visit https://asterix-gerrit.ics.uci.edu/1243 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I701b271bc6dc78e67274fa845dec013756843a70 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
