Michael Blow has posted comments on this change. Change subject: Wait For Metadata Registration Before Active, Etc. ......................................................................
Patch Set 4: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/GarbageCollector.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/GarbageCollector.java: Line 52: break; > Should we log when we start/quit the thread? Might be interesting to be abl Done https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java: Line 89: private static final Logger LOGGER = Logger.getLogger(MetadataManager.class.getName()); > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataManager.java: Line 677: void setRebindMetadataNode(boolean rebindMetadataNode); > Do we need all those here? Done https://asterix-gerrit.ics.uci.edu/#/c/1247/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/AsterixStateProxy.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/AsterixStateProxy.java: Line 58: public IMetadataNode getMetadataNode() { > Does anybody use this? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1247 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48d7c10b3e43181ec307f7d890ba721f61bc2ab0 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
