Ian Maxon has posted comments on this change. Change subject: Tests for ASTERIXDB-1636 ......................................................................
Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1248/2/asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixRestartIT.java File asterixdb/asterix-installer/src/test/java/org/apache/asterix/installer/test/AsterixRestartIT.java: Line 37: public class AsterixRestartIT { > Please put some description of the class here - what this is for. Done https://asterix-gerrit.ics.uci.edu/#/c/1248/2/asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.1.ddl.aql File asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.1.ddl.aql: Line 1: drop dataverse twitter if exists; > #1. We normally put the license header to each test, right? Done for both. https://asterix-gerrit.ics.uci.edu/#/c/1248/2/asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.9.sleep.aql File asterixdb/asterix-installer/src/test/resources/integrationts/restart/queries/feed-restart/issue-1636/issue-1636.9.sleep.aql: Line 25: */ > Is this correct description? Nope, that's just from the other example of that type of test file. -- To view, visit https://asterix-gerrit.ics.uci.edu/1248 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1521f1d53121b67677778ac123e49e731932c85 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-HasComments: Yes
