Steven Jacobs has posted comments on this change. Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure function calls ......................................................................
Patch Set 11: (13 comments) Addressed Sonar issues. All of the formatting is coming from the Asterix formatter. https://asterix-gerrit.ics.uci.edu/#/c/1057/11/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java: Line 129: false, (subTree.getDataSourceRef().getValue().getInputs().get(0).getValue() > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1057/11/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IAccessMethod.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IAccessMethod.java: Line 82: * @param afterSelectRefs > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1057/11/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java: Line 128: // Recursively check the given plan whether the desired pattern exists in it. > MAJOR SonarQube violation: Done Line 129: // If so, try to optimize the plan. > MAJOR SonarQube violation: Done Line 133: // We found an optimization here. Don't need to optimize this operator again. > MAJOR SonarQube violation: Done Line 138: // We found an optimization here. Don't need to optimize this operator again. > MAJOR SonarQube violation: Done Line 155: Map<IAccessMethod, AccessMethodAnalysisContext> analyzedAMs = new TreeMap<IAccessMethod, AccessMethodAnalysisContext>(); > MAJOR SonarQube violation: Done Line 170: if (chosenIndexes == null || chosenIndexes.size() == 0) { > MAJOR SonarQube violation: Done Line 234: false, (subTree.getDataSourceRef().getValue().getInputs().get(0).getValue() > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1057/11/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java: Line 445: false, (subTree.getDataSourceRef().getValue().getInputs().get(0).getValue() > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1057/11/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorManipulationUtil.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/util/OperatorManipulationUtil.java: Line 82: public static boolean setOperatorMode(AbstractLogicalOperator op, IOptimizationContext context) > MAJOR SonarQube violation: Done Line 85: boolean change = false; > MAJOR SonarQube violation: Done Line 85: boolean change = false; > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1057 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
