Steven Jacobs has posted comments on this change.

Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure 
function calls
......................................................................


Patch Set 12:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java:

Line 190:         if (annotation != null && !((Boolean) annotation)) {
> why that is moved out from OperatorPropertiesUtil?
I changed OperatorPropertiesUtil.isMovable to return false in the case of a 
nonPure call, but in this case this move is actually okay unless the annotation 
explicitly exists.


https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java:

Line 668:     //Get Variables used by afterSelectRefs that were created before 
the datasource
> I'm not sure if I understand well how this method is used.
This method isn't getting used in the join case.


https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IAccessMethod.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IAccessMethod.java:

Line 82:      * 
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1057/12/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IOptimizableFuncExpr.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IOptimizableFuncExpr.java:

Line 80:     ILogicalExpression[] getConstantExpressions();
> Why non-pure requires the addition of getConstantExpressions()?
This is just a quick way to find out whether there are any constants involved 
without needing to iterate through the list. It's used once in BTreeAccessMethod


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1057
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137
Gerrit-PatchSet: 12
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Preston Carman <prest...@apache.org>
Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu>
Gerrit-Reviewer: Taewoo Kim <wangs...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to