Michael Blow has posted comments on this change.

Change subject: Fix / Enforce Hyracks Dependency Correctness
......................................................................


Patch Set 3:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1277/3/hyracks-fullstack/algebricks/algebricks-compiler/pom.xml
File hyracks-fullstack/algebricks/algebricks-compiler/pom.xml:

Line 68:       <version>3.1</version>
> Do we have a variable for this somewhere else in a parent POM?
1. For the record, I hate these versions stored in properties- they get out of 
date right away- if we want to use this we should at least do it with 
dependencyManagement, which perhaps the IDEs understand.
2. No, it's not in a parent POM.


https://asterix-gerrit.ics.uci.edu/#/c/1277/3/hyracks-fullstack/algebricks/algebricks-runtime/pom.xml
File hyracks-fullstack/algebricks/algebricks-runtime/pom.xml:

Line 73:       <version>20090211</version>
> I think there's a variable for this too, maybe it's in Asterix though.
We don't have this as a variable in hyracks.


https://asterix-gerrit.ics.uci.edu/#/c/1277/3/hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-2.x/pom.xml
File hyracks-fullstack/hyracks/hyracks-hdfs/hyracks-hdfs-2.x/pom.xml:

Line 75:           <artifactId>hadoop-hdfs</artifactId>
> Why specify a version here? It should be managed I think
I made it managed to fit in; it wasn't before.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1277
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b7ed1faf17f5890542de000426a0ce3150bde74
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-HasComments: Yes

Reply via email to