Steven Jacobs has posted comments on this change. Change subject: Enhanced Insert AQL ......................................................................
Patch Set 21: (5 comments) I went ahead and made the in-line comment changes. https://asterix-gerrit.ics.uci.edu/#/c/1150/21/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: Line 172: || chosenIndex.getIndexType() == IndexType.LENGTH_PARTITIONED_NGRAM_INVIX > Pull chosenIndex.getIndexType() out? Done https://asterix-gerrit.ics.uci.edu/#/c/1150/21/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: Line 1870: > Why the empty line? Done https://asterix-gerrit.ics.uci.edu/#/c/1150/21/asterixdb/asterix-doc/src/site/markdown/aql/manual.md File asterixdb/asterix-doc/src/site/markdown/aql/manual.md: Line 838: The optional "as Variable" provides a variable binding for the inserted records, which can be used in the "returning" clause > period. Done Line 839: The optional "returning Query" allows users to run simple queries/functions on the records returned by the insert > period. Done Line 840: This query cannot refer to any datasets > period. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1150 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65789d2a861d15232dd29156a6987d0635ec6c94 Gerrit-PatchSet: 21 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
