Ian Maxon has posted comments on this change.

Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
......................................................................


Patch Set 2:

(3 comments)

Only really nits/questions, I think I understand what was happening. If a large 
object were to hit the guard for not leaving a record at the very end it would 
not trigger the large object version of logpage allocation.

https://asterix-gerrit.ics.uci.edu/#/c/1296/2/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
File 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java:

Line 89:     public static final int TRUNCATE_THRESHOLD = 16384;
Why this number? And why the fix for the truncation? I can see where maybe this 
is an issue but im puzzled as to the context


https://asterix-gerrit.ics.uci.edu/#/c/1296/2/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
File 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java:

Line 109:         appendChannel = getFileChannel(appendLSN.get(), false);
Might be good for that to just be a static final variable. I get why it's 0 but 
only from reading the refactoring of getAndInitNewPage/LargePage


Line 158:         final int logSize = logRecord.getLogSize();
The 'final' here is just for legibility, yes?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1296
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Reply via email to