Michael Blow has posted comments on this change.

Change subject: ASTERIXDB-1696 - Big Object Spanning Log File Boundary
......................................................................


Patch Set 2:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1296/2/asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
File 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java:

Line 89:     public static final int TRUNCATE_THRESHOLD = 16384;
> Why this number? And why the fix for the truncation? I can see where maybe 
I like powers of two, and seemed like a decent amount of data to print.  The 
context is that my 20MB line was crashing IDEA, and is pretty useless when 
printed.


https://asterix-gerrit.ics.uci.edu/#/c/1296/2/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java
File 
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java:

Line 109:         appendChannel = getFileChannel(appendLSN.get(), false);
> Might be good for that to just be a static final variable. I get why it's 0
Done


Line 158:         final int logSize = logRecord.getLogSize();
> The 'final' here is just for legibility, yes?
Yes


Line 189:                 } catch (InterruptedException e) {
> CRITICAL SonarQube violation:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1296
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd5ac08a8bcf4a1e0804aa05bd7e52169a0cf1bc
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Reply via email to