Michael Blow has posted comments on this change.

Change subject: Deps++, Refactor ClusterManager
......................................................................


Patch Set 1:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1298/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/ClusterLifecycleListener.java:

Line 82:         Set<IClusterEventsSubscriber> subscribers = 
ClusterManagerProvider.getClusterManager().getRegisteredClusterEventSubscribers();
> MAJOR SonarQube violation:
Done


Line 108:         Set<IClusterEventsSubscriber> subscribers = 
ClusterManagerProvider.getClusterManager().getRegisteredClusterEventSubscribers();
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/1298/1/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManager.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManager.java:

Line 66:         String eventHome = asterixCluster == null ? null
> Seems that bad stuff could happen if eventHome is null ...
Done


https://asterix-gerrit.ics.uci.edu/#/c/1298/1/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManagerProvider.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/cluster/ClusterManagerProvider.java:

Line 31: public class ClusterManagerProvider {
> MAJOR SonarQube violation:
Done


Line 37:     private static final class Holder {
> MAJOR SonarQube violation:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1298
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic574f51133ed32f3b850640260f7faf598b12219
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Reply via email to