Yingyi Bu has posted comments on this change.

Change subject: Documentation cleanup.
......................................................................


Patch Set 4:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1295/4/asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser-new/classad-parser-new.3.ddl.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/external-library/classad-parser-new/classad-parser-new.3.ddl.aql:

Line 25: ("object-start"="["),
> I think that this will break the ClassAd parser.
Done


https://asterix-gerrit.ics.uci.edu/#/c/1295/4/asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/get-object-field-value/documentation-example/documentation-example.2.query.aql
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/get-object-field-value/documentation-example/documentation-example.2.query.aql:

Line 28:         return get-object-field-value($r1, "address")
> Did the result change as well?
I think gerrit is doing diff on different files?


https://asterix-gerrit.ics.uci.edu/#/c/1295/4/asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md
File asterixdb/asterix-doc/src/site/markdown/feeds/tutorial.md:

Line 240: - *excess.objects.discard*: Set to true if excess objects should be 
discarded. (Default: false)
> Is this changed in the code as well?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1295
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idcb2be81d1bfa37dd876cd36a7a5bb824bc3ab86
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyin...@gmail.com>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to