Steven Jacobs has posted comments on this change. Change subject: Add user-stream for Twitter Adaptor ......................................................................
Patch Set 2: (3 comments) Oh, so this is something that is already sent in the "push feed?" https://asterix-gerrit.ics.uci.edu/#/c/1272/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java: Line 68: } > Yeah. Basically the only part that could be shrunk is the tweetList Okay, let's just leave as it is then. https://asterix-gerrit.ics.uci.edu/#/c/1272/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterRecordReaderFactory.java: Line 119: ? new TwitterPushRecordReader(TwitterUtil.getTwitterStream(configuration), > BLOCKER SonarQube violation: I'm guessing this doesn't get closed until the feed is dropped? Line 121: : new TwitterPushRecordReader(TwitterUtil.getTwitterStream(configuration), > BLOCKER SonarQube violation: I'm guessing this doesn't get closed until the feed is dropped? -- To view, visit https://asterix-gerrit.ics.uci.edu/1272 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99cdd4cb667306d378317616f9811dfce3e6d838 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
