Till Westmann has posted comments on this change. Change subject: Windows 10 Logs Constant Exceptions On CC/NC Death ......................................................................
Patch Set 1: (1 comment) Looks good, one question on the log message. https://asterix-gerrit.ics.uci.edu/#/c/1309/1/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java File hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java: Line 315: LOGGER.log(Level.WARNING, "Exception finishing connection", e); This is a little confusing. "Finish connection" could mean a) "close connection" or b) "finish the process of connecting". I think that it is b) in this case. Is that right? If so, should be have a more explicit log message? -- To view, visit https://asterix-gerrit.ics.uci.edu/1309 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec7a3ce23ab99d04b0fc0e0f832cce1a461e2df8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
