abdullah alamoudi has posted comments on this change. Change subject: Unify runtime type exceptions by using error code and message template. ......................................................................
Patch Set 8: (1 comment) Can we list the new exception classes created in the change commit message? can we add some explanation to the list as a guide to the review and a reference for subsequent commits (maybe it should go somewhere in the code)? https://asterix-gerrit.ics.uci.edu/#/c/1313/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/MetaFunctionToMetaVariableRule.java: undo this -- To view, visit https://asterix-gerrit.ics.uci.edu/1313 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fff8f5e64ffb027910a4899c0246b37ed5bce7 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
