Yingyi Bu has posted comments on this change. Change subject: Extract IPCIs out of ClusterControllerService ......................................................................
Patch Set 4: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1325/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerIPCI.java: Line 147: @Override is the code formatted? It seems there should be lines between methods. https://asterix-gerrit.ics.uci.edu/#/c/1325/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/HyracksClientInterfaceIPCI.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/HyracksClientInterfaceIPCI.java: Line 46: class HyracksClientInterfaceIPCI implements IIPCI { Remove "Hyracks" from the class name? Line 64: } catch (IPCException e) { > CRITICAL SonarQube violation: Pls address this? Line 117: } catch (IPCException e) { > CRITICAL SonarQube violation: Pls address this? Line 154: } catch (IPCException e) { > CRITICAL SonarQube violation: Pls address this? https://asterix-gerrit.ics.uci.edu/#/c/1325/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java: Line 511: private final class NodeControllerIPCI implements IIPCI { Can this IPCI be moved out too? -- To view, visit https://asterix-gerrit.ics.uci.edu/1325 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I403e61cc054a860bef6a71fa04393f4d9c368b36 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
