Yingyi Bu has posted comments on this change. Change subject: Fix Getting Operational Components for Search Operations ......................................................................
Patch Set 1: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1335/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java: Line 932: // The current mutable component is always added unless it is a search and it is not WS Line 935: operationalComponents.add(0, currentMemoryComponent); Why do you need IS_SEARCH check? Can't we remove the original line 933? To do that, we need to change cmc + i + 1 to i. https://asterix-gerrit.ics.uci.edu/#/c/1335/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndex.java: Line 975: if (currentMutableComponent.isReadable()) { Can't we remove the original line 972? To do that, we need to change cmc + i + 1 to i. https://asterix-gerrit.ics.uci.edu/#/c/1335/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java: Line 446: operationalComponents.add(0, memComponent); Can't we remove the original line 445? To do that, we need to change cmc + i + 1 to i. -- To view, visit https://asterix-gerrit.ics.uci.edu/1335 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If046ead8a9c1e32c2b8be55d7b035f23b71ed3ea Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
