Murtadha Hubail has posted comments on this change. Change subject: Fixed issues with Replication tests - Changed the way the log reader writes the newValue - Fixed bug with creating recovery plan ......................................................................
Patch Set 1: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1334/1//COMMIT_MSG Commit Message: Line 7: Fixed issues with Replication tests Add new line after the change title https://asterix-gerrit.ics.uci.edu/#/c/1334/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/ClusterStateManager.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/ClusterStateManager.java: Line 322: addActiveReplica(replica, partition, partitionRecoveryPlan); If you leave it like this, all active replicas for that partitions will be requested to take over the partition. You need to modify the addActiveReplica method and make it return a boolean. It should return true if an active replica was added, otherwise false. Then, if the call to addActiveReplica here returns true, you should break from the loop. Line 365: partitionRecoveryPlan.get(replica).add(partition.getPartitionId()); return true; Line 366: } return false; -- To view, visit https://asterix-gerrit.ics.uci.edu/1334 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I204a41311012dc348d4d41ae8bf6ec8554ab3dc3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Akshay Manchale <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-HasComments: Yes
