Michael Blow has posted comments on this change. Change subject: Ensure LogManager Doesn't Exceed the Size of the Log Page Queues ......................................................................
Patch Set 3: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1342/3/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java: Line 104: stashQ = new LinkedList<>(); let's make this LinkedBlockingQueue<>(numLogPages), since we can access it from multiple threads Line 208: if (appendPage.getLogPageSize() != logPageSize) { remove this block Line 696: emptyQ.offer(flushPage); emptyQ.offer(flushPage.getLogPageSize() == logMgr.getLogPageSize() ? flushPage : stashQ.remove()) -- To view, visit https://asterix-gerrit.ics.uci.edu/1342 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6427576a31090a057ee6a3d25e35eef5cdd86f8 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
