Ali Alsuliman has posted comments on this change. Change subject: [NO ISSUE][FUN] Add docs for array_fun ......................................................................
Patch Set 3: (11 comments) https://asterix-gerrit.ics.uci.edu/#/c/2794/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayRangeDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayRangeDescriptor.java: PS2, Line 50: stem_num > step_num Done PS2, Line 58: TODO: need to decide on what to do for NaN +-INF I assume we should return null for these cases, correct? https://asterix-gerrit.ics.uci.edu/#/c/2794/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayRepeatDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayRepeatDescriptor.java: PS2, Line 48: closed > Leave "closed" out? That shouldn't matter to the function. Done PS2, Line 54: TODO: should decide what to do for floating-points > What is happening today? Current implementation takes the integer part. Decimals are ignored. PS2, Line 55: closed > leave out? Done https://asterix-gerrit.ics.uci.edu/#/c/2794/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayReplaceDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayReplaceDescriptor.java: PS2, Line 59: open > leave out? Done PS2, Line 74: open > leave out? Done https://asterix-gerrit.ics.uci.edu/#/c/2794/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayStarDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayStarDescriptor.java: PS2, Line 59: open > leave out? Done https://asterix-gerrit.ics.uci.edu/#/c/2794/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySymDiffDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySymDiffDescriptor.java: PS2, Line 37: open > leave out? Done https://asterix-gerrit.ics.uci.edu/#/c/2794/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySymDiffnDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySymDiffnDescriptor.java: PS2, Line 37: open > leave out? Done https://asterix-gerrit.ics.uci.edu/#/c/2794/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayUnionDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayUnionDescriptor.java: PS2, Line 50: open > leave out? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2794 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I908338a7db9c0aa0b30acc6f9810327604a8368c Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
