Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2017][API] Access logs, log rotation ......................................................................
Patch Set 5: Code-Review-1 (3 comments) I'm concerned about the implications on extensions- I would prefer we consider this in depth. https://asterix-gerrit.ics.uci.edu/#/c/1915/5/asterixdb/asterix-app/src/main/resources/log4j2-cc.xml File asterixdb/asterix-app/src/main/resources/log4j2-cc.xml: PS5, Line 21: current current? https://asterix-gerrit.ics.uci.edu/#/c/1915/5/asterixdb/asterix-app/src/main/resources/log4j2-nc.xml File asterixdb/asterix-app/src/main/resources/log4j2-nc.xml: PS5, Line 21: current current? https://asterix-gerrit.ics.uci.edu/#/c/1915/5/asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.sh File asterixdb/asterix-server/src/main/opt/local/bin/start-sample-cluster.sh: PS5, Line 145: do we need the windows script updated as well? -- To view, visit https://asterix-gerrit.ics.uci.edu/1915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a8d76bec308b2fdb20c33370fc9e58a154ba968 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
