Taewoo Kim has posted comments on this change. Change subject: ASTERIXDB-1566, ASTERIXDB-1733: Hash Group By and Hash Join conform to the memory budget ......................................................................
Patch Set 23: (9 comments) https://asterix-gerrit.ics.uci.edu/#/c/1056/23/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java: Line 157: int numberOfGroupByColumns = gby.getGroupByList().size(); > + gby.getDecorList().size() ? Done https://asterix-gerrit.ics.uci.edu/#/c/1056/23/hyracks-fullstack/algebricks/algebricks-rewriter/pom.xml File hyracks-fullstack/algebricks/algebricks-rewriter/pom.xml: Line 67: <artifactId>hyracks-dataflow-std</artifactId> > Why rewriter needs runtime operator? Done https://asterix-gerrit.ics.uci.edu/#/c/1056/23/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java: Line 173: int numberOfGroupByColumns = gby.getGroupByList().size(); > + gby.getDecorList().size() ? Done Line 178: calculateGroupByTableEntrySize(memoryBudget, numberOfGroupByColumns), > It seems to me that you don't need the hash table size right now. You prob Done Line 429: int numberOfBits = numberOfGroupByColumns * 4 * 8; > numberOfBits --> numberOfBytes Discussed this with Yingyi and was told to ignore this. Line 438: long groupByTableByteSize = groupByTableSize * SerializableHashTable.getExpectedByteSizePerHashValue(); > This seems to create an unnecessary dependency. Discussed this with Yingyi and was told to ignore this. Line 438: long groupByTableByteSize = groupByTableSize * SerializableHashTable.getExpectedByteSizePerHashValue(); > A better way could be to defer the hash table size calculation to ExternalG Done https://asterix-gerrit.ics.uci.edu/#/c/1056/23/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/structures/SerializableHashTable.java: Line 32: * . > why period here? Done Line 36: * . > why period here? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1056 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b323e9a2141b4c1dd1652a360d2d9354d3bc3f5 Gerrit-PatchSet: 23 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
