abdullah alamoudi has posted comments on this change.

Change subject: [ASTERIXDB-2414][STO] Remove deleted component files from 
buffer cache
......................................................................


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2822/4//COMMIT_MSG
Commit Message:

PS4, Line 14: When activating an LSM index, we remove files of components
            :   that were merged into a bigger component but not cleaned up ye
> But on crash recovery, the buffer cache itself should be cleaned? Or, anoth
That is exactly what happens.
The validity check adds them to the buffer cache, then we delete them from disk 
but buffer cache still have them registered


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2822
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0f11bc222662e4b50c1b47b1dfa6b30d1463b2e
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Luo Chen <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to