Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2429] Fix the upsert of primary key index ......................................................................
Patch Set 2: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/2825/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/IndexInsertDeleteUpsertOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/IndexInsertDeleteUpsertOperator.java: Line 109: return b; need to call visitor.transform() on upsertIndicatorExpr Line 114: return visitor.visitIndexInsertDeleteUpsertOperator(this, arg); you need to go through all ILogicalOperatorVisitor implementations and make sure that upsertIndicatorExpr is handled properly there https://asterix-gerrit.ics.uci.edu/#/c/2825/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/InsertDeleteUpsertOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/InsertDeleteUpsertOperator.java: Line 64: private Object upsertIndicatorVarType; if upsertIndicatorVar's type is always a boolean then why do we need this field at all? Line 142: return visitor.visitInsertDeleteUpsertOperator(this, arg); need to go through all visitor implementations and make sure that upsertIndicatorVar is handled properly there. https://asterix-gerrit.ics.uci.edu/#/c/2825/2/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java: PS2, Line 364: VariableReferenceExpression If it's not a VariableReferenceExpression then let's throw NotImplementedException as getKeys() does -- To view, visit https://asterix-gerrit.ics.uci.edu/2825 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I925bd42ba67f70e94f5f5bc2d24151c8e2e20baf Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
