abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2414][STO] Fix name of merge files ......................................................................
Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2820/4/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndexFileManager.java: PS4, Line 212: String start = firstTimestampRange[0]; : String end = lastTimestampRange[1]; : if (end.compareTo(start) <= 0) { : throw new IllegalArgumentException( : "A Merge file must have end greater than start. Found end: " + end + " and start: " + start); : } : // Get the range of timestamps by taking the earliest and the latest timestamps : return new LSMComponentFileReferences(baseDir.getChild(start + DELIMITER + end), null, null); : } > I previously had the same doubt about the logic here, but then I found the Mmmm, how would it break storage? This is still a bug because of the following: When a merge completes, then a crash happens before we delete the old components, on bootstrap, instead of deleting the old components, we delete the new merged component. This gets even worse if we deleted some of the old components but not all of them, because then we would delete the merged components even though not all of the old components are there. -- To view, visit https://asterix-gerrit.ics.uci.edu/2820 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I861765bc0f293bdfdf0285f97884d536204fdb1e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
