Till Westmann has posted comments on this change. Change subject: Enable extension of IDataFormat ......................................................................
Patch Set 1: (1 comment) The SQ comments in AqlMetadataProvider are spot-on, please take a look. Also, it seems that the language compilation provider is not the right place for a data format provider. https://asterix-gerrit.ics.uci.edu/#/c/1349/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/ILangCompilationProvider.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/ILangCompilationProvider.java: Line 57: IDataFormatProvider getDataFormatProvider(); This doesn't seem to be the right interface for a data format provider. Everything else on this interface seems to be about language translation while the data format seems to be about execution (and orthogonal to the language). -- To view, visit https://asterix-gerrit.ics.uci.edu/1349 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b3e26fbb4a5da9ae4522b228991155f1a06d854 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
