Yingyi Bu has posted comments on this change. Change subject: Enable extension of IDataFormat ......................................................................
Patch Set 4: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1349/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/DefaultStatementExecutorFactory.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/DefaultStatementExecutorFactory.java: Line 34: return new QueryTranslator(aqlStatements, conf, compilationProvider, FormatUtils::getDefaultFormat); To be really extensible, should IDataFormat be a parameter in the create method, similar to the compilation provider? https://asterix-gerrit.ics.uci.edu/#/c/1349/4/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/GlobalRecoveryManager.java: Line 111: FormatUtils::getDefaultFormat); Extensibility v.s. hard coded? -- To view, visit https://asterix-gerrit.ics.uci.edu/1349 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b3e26fbb4a5da9ae4522b228991155f1a06d854 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
