Murtadha Hubail has submitted this change and it was merged. Change subject: [NO ISSUE][FAIL] Improve Error Message ......................................................................
[NO ISSUE][FAIL] Improve Error Message - user model changes: no - storage format changes: no - interface changes: no Change-Id: I0b7d4663452e83007cafed4dcd54aedbf09bdc84 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2843 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> Reviewed-by: abdullah alamoudi <[email protected]> --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Anon. E. Moose #1000171: abdullah alamoudi: Looks good to me, approved Jenkins: Verified; No violations found; ; Verified Murtadha Hubail: Looks good to me, but someone else must approve diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java index 02941d1..92295e7 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java @@ -572,7 +572,7 @@ MetadataManager.INSTANCE.commitTransaction(mdTxnCtx); return; } else { - throw new CompilationException(ErrorCode.DATASET_EXISTS, sourceLoc, datasetName); + throw new CompilationException(ErrorCode.DATASET_EXISTS, sourceLoc, datasetName, dataverseName); } } Datatype dt = MetadataManager.INSTANCE.getDatatype(metadataProvider.getMetadataTxnContext(), diff --git a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties index ee88010..63e0cda 100644 --- a/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties +++ b/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties @@ -144,7 +144,7 @@ 1069 = Cannot drop index \"%1$s\". Drop dataset \"%1$s\" to remove this index 1070 = Metadata error. %1$s 1071 = A dataverse with this name %1$s already exists. -1072 = A dataset with this name %1$s already exists. +1072 = A dataset with name %1$s already exists in dataverse %2$s 1073 = Cannot resolve alias reference for undefined identifier %1$s 1074 = Cannot resolve ambiguous alias reference for identifier %1$s 1075 = Inside limit clauses, it is disallowed to reference a variable having the same name as any variable bound in the same scope as the limit clause. -- To view, visit https://asterix-gerrit.ics.uci.edu/2843 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b7d4663452e83007cafed4dcd54aedbf09bdc84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]>
