Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-2017][API] Access logs, log rotation
......................................................................


Patch Set 5:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1915/16/asterixdb/asterix-app/src/main/resources/log4j2.xml
File asterixdb/asterix-app/src/main/resources/log4j2.xml:

PS16, Line 33: 
> shouldn't we use a different (i.e. explicit) logger here, that is specific 
Sure, I changed it to log as the class of the CLF logger itself.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1915
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a8d76bec308b2fdb20c33370fc9e58a154ba968
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Taewoo Kim <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to