Dmitry Lychagin has posted comments on this change. Change subject: [NO-ISSUE][COMP] Miscellaneous Fixes in Compiler ......................................................................
Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2858/1/hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/constraints/AlgebricksAbsolutePartitionConstraint.java File hyracks-fullstack/algebricks/algebricks-common/src/main/java/org/apache/hyracks/algebricks/common/constraints/AlgebricksAbsolutePartitionConstraint.java: Line 31: Arrays.sort(this.locations); Good catch. Can you extract it into a separate change? I'll approve it right away. https://asterix-gerrit.ics.uci.edu/#/c/2858/1/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java: Line 103: IVariableTypeEnvironment env2 = this.computeInputTypeEnvironment(ctx); how is this different? aggregate operator only has one input, so the input's output type environment is the aggregate's input environment. https://asterix-gerrit.ics.uci.edu/#/c/2858/1/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/AbstractIntroduceGroupByCombinerRule.java: Line 91: newGbyLiveVars.add(usedDecorVars.get(0)); do you have a testcase that was fixed by this? Can you include it into this change? -- To view, visit https://asterix-gerrit.ics.uci.edu/2858 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfc9459d0ccfc257e2c1b15f32d2697dcfbfcf42 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
