Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/2874
to look at the new patch set (#4).
Change subject: [ASTERIX-2430][COMP] Avoid inlining function calls in WITH in
AST rewritting
......................................................................
[ASTERIX-2430][COMP] Avoid inlining function calls in WITH in AST rewritting
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
The inlineWithExperssion() call in QueryRewritter inlines with/let
experssion blindly. This can cause problem when the function call is on
the DoNotInlineFuncs list. We can safely skip the inlining of function
calls in the AST rewritting part as the calls that are not on the
DoNotInlineFuncs list will be inlined by InlineVariablesRule later.
Change-Id: I18afbe4165ca84c790d7693a7a7bd5f6fd53187a
---
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/ASTERIXDB-2430.sqlpp
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/ASTERIXDB-2430.plan
M
asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/InlineWithExpressionVisitor.java
3 files changed, 117 insertions(+), 0 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/74/2874/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/2874
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I18afbe4165ca84c790d7693a7a7bd5f6fd53187a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>