Steven Jacobs has posted comments on this change. Change subject: Fixed bug with pull-based channel ......................................................................
Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2876/1/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java File asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java: Line 98: if (push) { > Could you add two line comments to the following so we would know why it's Done Line 99: recordPrinterFactory = new ARecordPrinterFactory((ARecordType) recordType).createPrinter(); > record type is the actual data records. Done Line 100: } else { > record type is a list of subscription ids Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2876 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If758f9e8d5c66c5badd819ad877d269bee4408c8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
