Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-2017][API] Access logs, log rotation ......................................................................
Patch Set 25: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1915/25/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/CLFLogger.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/CLFLogger.java: PS25, Line 113: logLineBuilder.append(clientIp); : //identd value - not relevant here : logLineBuilder.append(" - "); : //no http auth or any auth either for that matter : logLineBuilder.append(" - ["); : logLineBuilder.append(requestTime); : logLineBuilder.append("] "); : logLineBuilder.append(reqLine); : logLineBuilder.append(" ").append(statusCode); : logLineBuilder.append(" ").append(respSize); : logLineBuilder.append(" ").append(userAgentRef); : accessLogger.log(Level.forName(ACCESS_LOG_LEVEL, 550), logLineBuilder.toString()); : respSize = 0; : logLineBuilder = new StringBuilder(); > can we make this more CLF compliant? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a8d76bec308b2fdb20c33370fc9e58a154ba968 Gerrit-PatchSet: 25 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
