Steven Jacobs has posted comments on this change. Change subject: ASTERIXDB-1608, ASTERIXDB-1617 Match user query for nonpure function calls ......................................................................
Patch Set 22: (2 comments) Made the last change. I'll rebase now. https://asterix-gerrit.ics.uci.edu/#/c/1057/22/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushFieldAccessRule.java: Line 190: if (annotation != null && !((Boolean) annotation)) { > why not use OperatorPropertiesUtil? I changed OperatorPropertiesUtil.isMovable to check whether the operator is nonPure or not (it shouldn't be movable if it is). This rule is the one case I found where it is okay to push the field access through a non pure, so I couldn't use the altered isMovable https://asterix-gerrit.ics.uci.edu/#/c/1057/22/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java: Line 195: boolean foundHere = checkAndApplyTheSelectTransformationRule(op.getInputs().get(i), context); > for(Mutable<ILogicalOperator> inputOpRef : op.getInputs() ) Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1057 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dec322b30835625430c06acd7626d902bada137 Gerrit-PatchSet: 22 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Preston Carman <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
