Till Westmann has posted comments on this change. Change subject: Parameter documentation for nc service installtion. ......................................................................
Patch Set 3: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1355/3/asterixdb/asterix-doc/src/site/markdown/ncservice.md File asterixdb/asterix-doc/src/site/markdown/ncservice.md: Line 138: | command | The command for the slave process | cbasnc | The default value seems wrong - we either need to fix the docs or the code. Line 142: | metadata.port | The metadata communication port on the metadata node. This parameter should only present in the section of the metadata NC | 0 | s/present/be present/? Line 159: | txn.lock.timeout.waitthreshold | Time out (in milliseconds) of waiting a lock | 60000 | s/of waiting a lock/of waiting for a lock/ Also, it seems that those timeouts are pretty long .. Line 163: | txn.log.checkpoint.lsnthreshold | The checkpoint threshold (in terms of LSN number) for transection logs | 67108864 | I'm not sure I understand. -- To view, visit https://asterix-gerrit.ics.uci.edu/1355 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2e0c4e4dd41e966cc5fcebb423b7ca1be218de9d Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
