Ian Maxon has posted comments on this change. Change subject: [NO ISSUE] Fix log directory initialization ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2906/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java: PS1, Line 49: File.separator > this will result in <default dir>///logs won't it? i.e. i think you shoudl right now what the previous version evaluates to in asterix is "/tmp/asterixdb/logscc.log, and so on. so my preference was to have an extraneous slash which should cause nothing besides cosmetic issues, rather than have it omit one. PS1, Line 50: File.separator > why does this have to have a trailing /? we don't do this for any other pa doesn't have to, adding it here just stopped it from being repeated in the log config factories -- To view, visit https://asterix-gerrit.ics.uci.edu/2906 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4e11e030a8ffa387e1fa234ed9ad9e3fe380c5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-HasComments: Yes
