abdullah alamoudi has submitted this change and it was merged. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators ......................................................................
[NO ISSUE][TXN] Fix extension datasets tuple translators Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Reviewed-on: https://asterix-gerrit.ics.uci.edu/2908 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: abdullah alamoudi <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> --- M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java A asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java 2 files changed, 33 insertions(+), 4 deletions(-) Approvals: Anon. E. Moose #1000171: abdullah alamoudi: Looks good to me, but someone else must approve Jenkins: Verified; No violations found; ; Verified Murtadha Hubail: Looks good to me, approved diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java index d25f488..ebb9cac 100644 --- a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java +++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java @@ -29,16 +29,16 @@ private static final long serialVersionUID = 1L; private final ExtensionMetadataDatasetId indexId; - private final transient IMetadataEntityTupleTranslator<T> tupleTranslator; + private final transient IMetadataEntityTupleTranslatorFactory<T> tupleTranslatorFactory; public ExtensionMetadataDataset(MetadataIndexImmutableProperties indexProperties, int numFields, IAType[] keyTypes, List<List<String>> keyNames, int numSecondaryIndexKeys, ARecordType payloadType, boolean isPrimaryIndex, int[] primaryKeyIndexes, ExtensionMetadataDatasetId indexId, - IMetadataEntityTupleTranslator<T> tupleTranslator) { + IMetadataEntityTupleTranslatorFactory<T> tupleTranslatorFactory) { super(indexProperties, numFields, keyTypes, keyNames, numSecondaryIndexKeys, payloadType, isPrimaryIndex, primaryKeyIndexes); this.indexId = indexId; - this.tupleTranslator = tupleTranslator; + this.tupleTranslatorFactory = tupleTranslatorFactory; } public ExtensionMetadataDatasetId getId() { @@ -46,6 +46,6 @@ } public IMetadataEntityTupleTranslator<T> getTupleTranslator() { - return tupleTranslator; + return tupleTranslatorFactory.createTupleTranslator(); } } diff --git a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java new file mode 100644 index 0000000..e472383 --- /dev/null +++ b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.asterix.metadata.api; + +import java.io.Serializable; + +public interface IMetadataEntityTupleTranslatorFactory<T> extends Serializable { + + /** + * @return an instance of IMetadataEntityTupleTranslator + */ + IMetadataEntityTupleTranslator<T> createTupleTranslator(); +} -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]>
