Michael Blow has submitted this change and it was merged. Change subject: [NO ISSUE][FUN] Allow extensions to add aggregate functions ......................................................................
[NO ISSUE][FUN] Allow extensions to add aggregate functions - user model changes: yes - storage format changes: no - interface changes: no Details: - Make aggregate function related methods public in BuiltInFunctions, so product extensions can register their own aggregate functions Change-Id: I5bec031c833938e38c989acd7aa43b8e93669602 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2840 Reviewed-by: abdullah alamoudi <[email protected]> Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> --- M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: abdullah alamoudi: Looks good to me, approved Jenkins: Verified; No violations found; Verified Objections: Anon. E. Moose #1000171: Violations found Jenkins: Violations found diff --git a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java index d2c8269..1df617e 100644 --- a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java +++ b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java @@ -2046,19 +2046,19 @@ registeredFunctions.put(fi, functionInfo); } - private static void addAgg(FunctionIdentifier fi) { + public static void addAgg(FunctionIdentifier fi) { builtinAggregateFunctions.add(getAsterixFunctionInfo(fi)); } - private static void addLocalAgg(FunctionIdentifier fi, FunctionIdentifier localfi) { + public static void addLocalAgg(FunctionIdentifier fi, FunctionIdentifier localfi) { aggregateToLocalAggregate.put(getAsterixFunctionInfo(fi), getAsterixFunctionInfo(localfi)); } - private static void addIntermediateAgg(FunctionIdentifier fi, FunctionIdentifier globalfi) { + public static void addIntermediateAgg(FunctionIdentifier fi, FunctionIdentifier globalfi) { aggregateToIntermediateAggregate.put(getAsterixFunctionInfo(fi), getAsterixFunctionInfo(globalfi)); } - private static void addGlobalAgg(FunctionIdentifier fi, FunctionIdentifier globalfi) { + public static void addGlobalAgg(FunctionIdentifier fi, FunctionIdentifier globalfi) { aggregateToGlobalAggregate.put(getAsterixFunctionInfo(fi), getAsterixFunctionInfo(globalfi)); globalAggregateFunctions.add(getAsterixFunctionInfo(globalfi)); } @@ -2067,15 +2067,15 @@ builtinUnnestingFunctions.put(getAsterixFunctionInfo(fi), returnsUniqueValues); } - private static void addSerialAgg(FunctionIdentifier fi, FunctionIdentifier serialfi) { + public static void addSerialAgg(FunctionIdentifier fi, FunctionIdentifier serialfi) { aggregateToSerializableAggregate.put(getAsterixFunctionInfo(fi), getAsterixFunctionInfo(serialfi)); } - private static void addScalarAgg(FunctionIdentifier fi, FunctionIdentifier scalarfi) { + public static void addScalarAgg(FunctionIdentifier fi, FunctionIdentifier scalarfi) { scalarToAggregateFunctionMap.put(getAsterixFunctionInfo(scalarfi), getAsterixFunctionInfo(fi)); } - private static void addDistinctAgg(FunctionIdentifier distinctfi, FunctionIdentifier regularscalarfi) { + public static void addDistinctAgg(FunctionIdentifier distinctfi, FunctionIdentifier regularscalarfi) { distinctToRegularScalarAggregateFunctionMap.put(getAsterixFunctionInfo(distinctfi), getAsterixFunctionInfo(regularscalarfi)); } -- To view, visit https://asterix-gerrit.ics.uci.edu/2840 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5bec031c833938e38c989acd7aa43b8e93669602 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]>
