abdullah alamoudi has submitted this change and it was merged. Change subject: [NO ISSUE][COMP] Fix TypeComputeUtils.getResultType ......................................................................
[NO ISSUE][COMP] Fix TypeComputeUtils.getResultType - user model changes: no - storage format changes: no - interface changes: no Details: - Fix TypeComputeUtils.getResultType to either return unknowable or missable type. Change-Id: Id881f2a5ad8134a3e86b2b08ce1acdc53c4948a2 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2928 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Dmitry Lychagin <[email protected]> --- M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Anon. E. Moose #1000171: Jenkins: Verified; No violations found; ; Verified Dmitry Lychagin: Looks good to me, approved diff --git a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java index 806235c..448ab4c 100644 --- a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java +++ b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java @@ -169,8 +169,7 @@ IAType resultType = type; if ((category & NULLABLE) != 0 || (category & NULL) != 0) { resultType = AUnionType.createUnknownableType(resultType); - } - if ((category & MISSABLE) != 0 || (category & MISSING) != 0) { + } else if ((category & MISSABLE) != 0 || (category & MISSING) != 0) { resultType = AUnionType.createMissableType(resultType); } return resultType; -- To view, visit https://asterix-gerrit.ics.uci.edu/2928 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id881f2a5ad8134a3e86b2b08ce1acdc53c4948a2 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]>
