Change in asterixdb[master]: [ASTERIXDB-2445][COMP] Nullable category handling in TypeCom...

[Dmitry Lychagin (Code Review)]

Dmitry Lychagin has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2932

Change subject: [ASTERIXDB-2445][COMP] Nullable category handling in 
TypeComputeUtils.getResultType()
......................................................................

[ASTERIXDB-2445][COMP] Nullable category handling in 
TypeComputeUtils.getResultType()

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- TypeComputeUtils.getResultType() currently makes the output type unknowable 
when
  nullable category is passed. It should make it nullable instead

Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1
---
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/32/2932/1

diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
index 448ab4c..f1f1be3 100644
--- 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
+++ 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/TypeComputeUtils.java
@@ -168,8 +168,9 @@
         }
         IAType resultType = type;
         if ((category & NULLABLE) != 0 || (category & NULL) != 0) {
-            resultType = AUnionType.createUnknownableType(resultType);
-        } else if ((category & MISSABLE) != 0 || (category & MISSING) != 0) {
+            resultType = AUnionType.createNullableType(resultType);
+        }
+        if ((category & MISSABLE) != 0 || (category & MISSING) != 0) {
             resultType = AUnionType.createMissableType(resultType);
         }
         return resultType;

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2932
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bb1e96c5a4f83a3d281811246da183d1a31e0f1
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin <dmitry.lycha...@couchbase.com>