Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2447][COMP] Parameter rewriting for if_missing, if_null functions ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2935/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/InjectTypeCastForSwitchCaseRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/InjectTypeCastForSwitchCaseRule.java: Line 99: if (rewriteFunction(op, func, context)) { > consider this? I'd keep it as is. It looks aligned with the previous block (lines 94-97) and we cannot merge 2 ifs in that one. -- To view, visit https://asterix-gerrit.ics.uci.edu/2935 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I768d8236f5b0ccb9a850304ffedd3686d911702d Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
